Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Showcasing Mapz app #2392

Merged
merged 4 commits into from
Jan 25, 2024
Merged

Showcasing Mapz app #2392

merged 4 commits into from
Jan 25, 2024

Conversation

nbelthan
Copy link
Contributor

Thank you for your contribution to the IC Developer Portal.
Before submitting your Pull Request, please make sure that:

@nbelthan nbelthan requested a review from a team as a code owner January 24, 2024 20:00
@sa-github-api
Copy link

Dear @nbelthan,

In order to potentially merge your code in this open-source repository and therefore proceed with your contribution, we need to have your approval on DFINITY's CLA.

If you decide to agree with it, please visit this issue and read the instructions there. Once you have signed it, re-trigger the workflow on this PR to see if your code can be merged.

— The DFINITY Foundation

@jennifertrin
Copy link
Contributor

Dear @nbelthan,

In order to potentially merge your code in this open-source repository and therefore proceed with your contribution, we need to have your approval on DFINITY's CLA.

If you decide to agree with it, please visit this issue and read the instructions there. Once you have signed it, re-trigger the workflow on this PR to see if your code can be merged.

— The DFINITY Foundation

Hello @nbelthan Can you please complete these CLA steps?

@nbelthan
Copy link
Contributor Author

Hello @nbelthan Can you please complete these CLA steps?

Hello Jennifer, all the checks are successful now.

@jennifertrin jennifertrin merged commit ddfb409 into dfinity:master Jan 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jennifertrin jennifertrin jennifertrin approved these changes

Assignees
No one assigned
Labels
external-contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nbelthan @sa-github-api @jennifertrin